[Xapian-devel] Re: [Xapian-commits] 7817: trunk/xapian-core/ trunk/xapian-core/common/

[Richard Boulton]

Olly Betts wrote:
> If this is only required by the quartz log stuff, I wonder if we should
> just drop that code.
> 
> It doesn't get used unless you touch "log" in a quartz database by hand,
> but that's not documented anywhere so I doubt anybody except you and me
> knows to even try it!  We could document it, but I never actually found
> it a useful debugging aid, and haven't used it at all in years.  Plus
> quartz will be deprecated for new systems as of 1.0 anyway.

All true, and good points - I haven't ever really used it either.

> But I suspect support for 64 bit integers is also required for the debug
> logging code.

Quite possibly - we've not got round to building with debug logging 
turned on yet.

> Hmm, and I don't understand how this worked for MSVC before this patch
> if it gives an error now.  Or why I haven't seen an error building for
> mingw.

I think it's only needed for the newer compilers, because time_t only 
recently became a 64 bit quantity.  And GetProcessId similarly, I 
suppose.  Charlie will know more detail.

> A testcase is a good idea, but it's going to be tricky for me to
> exercise it in a cross-build...

Fair point.  I've written one anyway, but I can't test it either.  I'll 
add it to a bug report, so we don't forget to look into this.

-- 
Richard