[Xapian-devel] Re: [Xapian-commits] 7817: trunk/xapian-core/ trunk/xapian-core/common/

[Olly Betts]

On Fri, Mar 02, 2007 at 01:10:07PM +0000, Richard Boulton wrote:
> Olly Betts wrote:
> >Hmm, and I don't understand how this worked for MSVC before this patch
> >if it gives an error now.  Or why I haven't seen an error building for
> >mingw.
> 
> I think it's only needed for the newer compilers, because time_t only 
> recently became a 64 bit quantity.  And GetProcessId similarly, I 
> suppose.  Charlie will know more detail.

Ah, and I bet there's some C preprocessor magic or other trickery going
on so that programs can use the same runtime DLLs but just call a
different version of the functions concerned.

> >A testcase is a good idea, but it's going to be tricky for me to
> >exercise it in a cross-build...
> 
> Fair point.  I've written one anyway, but I can't test it either.  I'll 
> add it to a bug report, so we don't forget to look into this.

I suggest you commit it to HEAD anyway.  It can be tested with MSVC, and
if there's a bug in the test, the worst that can happen is it might stop
"make check" from working under native mingw when someone tries it,
until the problem is reported and fixed.

Cheers,
    Olly