[Xapian-devel] GSoC xapian node binding

[Liam]

On Wed, May 30, 2012 at 11:54 PM, Liam <xapian at networkimprov.net> wrote:

>
>
> On Wed, May 30, 2012 at 12:17 PM, Marius Tibeica <mtibeica at gmail.com>wrote:
>
>> done
>>
>
> Sorry I keep finding nits!
>

invoke() should do 'that->mBusy = true', and move that line to before the
'new AsyncOp(...)'

DECLARE_UTILS can now be global templates, I think:
  template<class T>
  handle<value> invoke(...) {
    // replace classn with T
  use invoke<Enquire>(...);

We didn't consider allowing sync use of the AssembleDocument function
(creates a document from a JS object spec). I'm fine leaving that async; it
really shouldn't be called synchronously. But something to ponder...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.xapian.org/pipermail/xapian-devel/attachments/20120531/b6b7c390/attachment.htm>