KMeans - Evaluation Results

[James Aylett]

On 17 Aug 2016, at 15:22, Richhiey Thomas <richhiey.thomas at gmail.com> wrote:

> I have a two questions about this since I haven't worked with PIMPL before:
> 
> 1) When I'm dealing with abstract classes, how do I make an Internal class for this? Because as I understand it, for every class we will have to make a new Internal class and then implement the functions within that Internal class. So I wouldn't need to make an Internal class for an abstract class, right?

Which abstract class are you thinking of?

> 2) Incase of classes like Point and Centroid, these aren't a part of the pubic API but are used internally almost everywhere. So I will need to define these in the Internal namespace?

You can just define them outside any namespace, which is what we use for a lot of Xapian's internal classes. For instance:

https://github.com/xapian/xapian/blob/master/xapian-core/api/emptypostlist.h

J

-- 
 James Aylett, +44 7976 212023
 Principal Consultant, Kittens with Jetpacks Ltd

 Registered company no 6587395
 19 Cottrell Court, Southern Way, London SE10 0DW