R bindings for Xapian - Project progress
james-xapian at tartarus.org
Sun Jun 12 18:46:06 BST 2016
On Sun, Jun 12, 2016 at 12:18:54PM +0530, Amanda Jayanetti wrote:
> I completely facilitated simple indexing with xapian_index function, and
> also developed a DatabaseWrapper. Only a few more modifications are
> remaining to completely facilitate simple search with xapian_search
Amanda -- that's great.
I did ask you a while ago to start using pull requests into your own
repo, so it's easier for mentors to work with you on the work you're
doing. This will become increasingly important going forward as you're
building on your earlier work, so please start doing this sooner
rather than later as it tends to take a little bit of time to become
comfortable with that way of working.
For instance, I'd have been able to point out before you committed to
master that all the files in man/ that you've added don't need to be
in the repo, because they're automatically generated from other source
code. (Having anything twice increases the chance it won't be in
sync.) I don't know if you'll need to add any specific rules or help
for running roxygen2, or if that's part of a normal R build process,
but either way I'd get rid of the generated files so there's one
"source of truth" in the codebase.
James Aylett, occasional trouble-maker
More information about the Xapian-devel