[Xapian-tickets] [Xapian] #50: SynonymPostList
Xapian
nobody at xapian.org
Sun Apr 19 17:39:32 BST 2009
#50: SynonymPostList
-------------------------+--------------------------------------------------
Reporter: olly | Owner: richard
Type: enhancement | Status: assigned
Priority: low | Milestone: 1.1.1
Component: Library API | Version: SVN trunk
Severity: minor | Resolution:
Keywords: | Blockedby:
Platform: All | Blocking: 104, 307
-------------------------+--------------------------------------------------
Comment(by richard):
I've attached the latest patch containing all the changes on the opsynonym
branch.
Coverage testing indicates that there is only one line added/changed by
which is not covered by tests: the handling for "factor == 0.0" in
QueryOptimiser::do_synonym() (ie, the line:
{{{
RETURN(do_or_like(query, 0.0));
}}}
near the end of queryoptimiser.cc
There are two FIXMEs added by the patch:
1) LocalSubMatch::make_synonym_postlist "FIXME - calculate the reltermfreq
to use". Currently, we're not trying to estimate the reltermfreq for
synonym queries - we should try to add something, but I don't think it
should block applying the patch (we should make a ticket so we don't
forget about it, though).
2) QueryOptimiser::do_synonym "FIXME - should we be doing something with
the wqf?" I think the answer is "no", but I've not thought it through
very carefully.
I think neither of these need block the patch being merged to trunk, and
would like to do so shortly after 1.1.0 is released.
--
Ticket URL: <http://trac.xapian.org/ticket/50#comment:23>
Xapian <http://xapian.org/>
Xapian
More information about the Xapian-tickets
mailing list