[Xapian-tickets] [Xapian] #50: SynonymPostList

[Xapian]

#50: SynonymPostList
-------------------------+--------------------------------------------------
 Reporter:  olly         |        Owner:  richard  
     Type:  enhancement  |       Status:  assigned 
 Priority:  low          |    Milestone:  1.1.1    
Component:  Library API  |      Version:  SVN trunk
 Severity:  minor        |   Resolution:           
 Keywords:               |    Blockedby:           
 Platform:  All          |     Blocking:  104, 307 
-------------------------+--------------------------------------------------

Comment(by olly):

 This is looking good.  Almost tempted to try to merge it for 1.1.0, but I
 think we should probably stick to getting it out the door.

 Patch review (to avoid too much probably pointless detailed explanation,
 I've just fixed bits which I think aren't at all controversial in SVN, but
 feel free to argue):

 In multimatch.cc, it would be nice to say in what situation {{{denom ==
 0}}} can happen as it isn't immediately clear to me (I'm guessing
 something like {{{OP_SYNONYM}}} being the top level query op?)

 In queryparser.lemony, line 360 onwards, you add a second vector subqs2 to
 allow us to carefully OP_OR the OP_SYNONYM-ed terms for each prefix in the
 "partial term" case, but in the "wildcard term" case, you just OP_SYNONYM
 all the terms using a single vector.  I think these two cases should be
 consistent (they're really just implicit vs explicit cases of the same
 thing), and I think we probably should OP_SYNONYM everything.

 Why does this new overloaded form of {{{Weight::init_()}}} have a
 {{{term}}} parameter when we always pass an empty string for it?  Is there
 some likely future use for this?

 Is there an easy testcase to add coverage for the missing line?

-- 
Ticket URL: <http://trac.xapian.org/ticket/50#comment:24>
Xapian <http://xapian.org/>
Xapian