[Xapian-tickets] [Xapian] #416: php bindings - get_values for ValueCountMatchSpy return resource

[Xapian]

#416: php bindings - get_values for ValueCountMatchSpy return resource
-----------------------------+----------------------------------------------
 Reporter:  overgroove       |       Owner:  olly 
     Type:  defect           |      Status:  new  
 Priority:  normal           |   Milestone:  1.1.4
Component:  Xapian-bindings  |     Version:       
 Severity:  normal           |    Keywords:       
Blockedby:                   |    Platform:  All  
 Blocking:                   |  
-----------------------------+----------------------------------------------
Changes (by richard):

  * milestone:  => 1.1.4


Comment:

 Thanks for the patch.  A few notes and questions:

  - Can the call to add_assoc_long() return an error?  Googling shows me
 that it has "int" as a return type, and I imagine it can fail for various
 reasons (it must allocate some memory, for a start), but I can't find any
 documentation of what the return type means.

  - Does add_assoc_long() take a copy of the string (or, indeed, does it
 allow it to be modified).  Again, I couldn't find any documentation of
 this, but if it doesn't take a copy, we'll be liable to get segfaults and
 buffer overruns if the array is accessed after the MatchSpy has been
 deallocated.

  - Does this patch actually make get_values() work usably for you?
 Ideally, we'd add a test to smoketest.php to ensure that it works, and
 continues to work.


 We're (well, I'm) just in the process of drafting a policy for the license
 which contributors need to give for their code to be included in the
 project; this patch is big enough that we'd need your agreement to license
 the code appropriately, assuming it works and we therefore want to merge
 it to trunk.  Basically, we need your permission to distribute the code
 under both the GPL and the MIT/X license.  Feel free to ask on IRC if you
 need details about this.

 Marking this ticket for consideration for 1.1.4.

-- 
Ticket URL: <http://trac.xapian.org/ticket/416#comment:1>
Xapian <http://xapian.org/>
Xapian