[Xapian-tickets] [Xapian] #416: php bindings - get_values for ValueCountMatchSpy return resource

[Xapian]

#416: php bindings - get_values for ValueCountMatchSpy return resource
-----------------------------+----------------------------------------------
 Reporter:  overgroove       |       Owner:  olly     
     Type:  defect           |      Status:  new      
 Priority:  normal           |   Milestone:  1.1.4    
Component:  Xapian-bindings  |     Version:  SVN trunk
 Severity:  normal           |    Keywords:           
Blockedby:                   |    Platform:  All      
 Blocking:                   |  
-----------------------------+----------------------------------------------
Changes (by olly):

  * version:  => SVN trunk


Comment:

 Cleaned up patch attached - fixes formatting, uses add_assoc_long_ex() to
 correctly handle terms with embedded zero bytes, and removes the pointless
 #define and random added blank line.

 Looking at the PHP source, add_assoc_long() returns SUCCESS or FAILURE,
 but since that appears not to be documented at all, nobody else in the
 world actually checks its return value.  I've ignored that for now.  It
 isn't obvious if the arguments are copied or not from the code - testing
 would probably be an easier way to check that.  Pretty much all calls in
 the wild seem to pass a constant string.

 This does really test coverage though, so not applying for now.

 FWIW, the FSF wouldn't regard a patch of this size as significant for
 copyright purposes:

 http://www.gnu.org/prep/maintain/maintain.html#Legally-Significant

-- 
Ticket URL: <http://trac.xapian.org/ticket/416#comment:2>
Xapian <http://xapian.org/>
Xapian