Xapian 1.4.0 released

[Kevin Duraj]

James,

I have submitted the following pull request 113
if the term is too large, resize it to MAX_SAFE_TERM_LENGTH instead of
throwing an exception.
https://github.com/xapian/xapian/pull/113

if (tname.size() > MAX_SAFE_TERM_LENGTH)
- throw Xapian::InvalidArgumentError("Term too long (> "
STRINGIZE(MAX_SAFE_TERM_LENGTH) "): " + tname);
+ tname.resize(MAX_SAFE_TERM_LENGTH)

- Kevin Duraj



On Fri, Jul 22, 2016 at 7:19 PM, Kevin Duraj <kevin.duraj at zefr.com> wrote:
> James,
>
> I would like to propose to change the following code while indexing a
> term that is larger than 245 characters and then crashing and aborting
> the entire index, we could rather truncate the term to 245 characters
> and continue with indexing.
>
> if (tname.size() > MAX_SAFE_TERM_LENGTH) throw
> Xapian::InvalidArgumentError("Term too long (> "
> STRINGIZE(MAX_SAFE_TERM_LENGTH) "): " + tname);
>
> Reference:
> https://github.com/xapian/xapian/blob/e3692bff7b7c25c8e09536889d5884d033199f36/xapian-core/backends/glass/glass_database.cc#L1083-L1084
>
> On Tue, Jul 12, 2016 at 10:13 AM, James Aylett
> <james-xapian at tartarus.org> wrote:
>> On Mon, Jul 11, 2016 at 02:02:56PM -0700, Kevin Duraj wrote:
>>
>>> You are saying that when I search for "delve Xapian 1.4"  on Google, a
>>> company worth of 491 Billion of Dollars and you saying that their top
>>> of the search result has nothing to do with Xapian.
>>>
>>> https://www.google.com/search?q=xapian+delve&ie=utf-8&oe=utf-8#q=delve+xapian+1.4
>>
>> Well, I'm not saying that it's nothing to do with Xapian: clearly the
>> page is about Xapian. However since it wasn't _created_ by the Xapian
>> project, it's not authoritative.
>>
>> Google search results are personalised; for me, the top hit for that
>> search is the Xapian Administrator's Guide, which correctly names the
>> command for 1.4 as xapian-delve (and the history of the
>> change).
>>
>> If I'm not logged into Google, I still get that document top, but the
>> Linux From Scratch one you found is in the list further down. I'd
>> guess the difference in ordering is down to your own personalisation
>> from Google, although of course we can never be certain with Google.
>>
>>> Whooo, that is strong. I don't think Google will ever call you for an
>>> Interview now *LOL*
>>
>> Kevin, I don't think sarcasm was called for here. Let's try to keep
>> our mailing lists and forums welcoming places that everyone can feel
>> comfortable!
>>
>> J
>>
>> --
>>   James Aylett, occasional trouble-maker
>>   xapian.org
>>